Exposing Timeout and Check_Mode Properties for Rest Send#253
Open
AKDRG wants to merge 1 commit intoCiscoDevNet:developfrom
Open
Exposing Timeout and Check_Mode Properties for Rest Send#253AKDRG wants to merge 1 commit intoCiscoDevNet:developfrom
AKDRG wants to merge 1 commit intoCiscoDevNet:developfrom
Conversation
AKDRG
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
mtarking,
sajagana,
samiib and
shrsr
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
Before the first request is made, the rest send object is not initialised. As a result, we are not able to set the timeout and check mode properties. Setting of timeout is crucial for restricting retries when errors occur and setting of check mode allows us to make a genuine GET request which is otherwise blocked.
Fix:
Introduce setters in the NDModule which sets the properties when the lazy initialisation happens, at the time of invoking the request method.